fix: resolve PR review comments - expand CI path filters and remove n…#824
Merged
Conversation
…on-null assertion
Shubhangi-Microsoft
requested review from
Avijit-Microsoft,
Prajwal-Microsoft,
Roopan-Microsoft,
Vinay-Microsoft,
aniaroramsft,
malrose07,
nchandhi and
toherman-msft
as code owners
April 23, 2026 06:59
Shubhangi-Microsoft
temporarily deployed
to
production
April 23, 2026 06:59 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
Roopan-Microsoft
approved these changes
Apr 23, 2026
Contributor
|
🎉 This PR is included in version 2.4.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes a minor update to the workflow trigger paths in
.github/workflows/docker-build.ymland a small code update inChatPanel.tsxto improve code safety. The workflow path changes simplify the path patterns, and the code change removes an unnecessary non-null assertion.Workflow trigger updates:
'src/App/src/**'and'src/App/server/**'with the broader'src/App/**'pattern for bothpushandworkflow_dispatchevents in.github/workflows/docker-build.yml. [1] [2]Code safety improvement:
!) from theonProductSelectprop inChatPanel.tsx, making the code safer and more idiomatic.…on-null assertionPurpose
Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information